Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Streamable w/ Writeable in SingleShardRequest and subclasses #43222

Merged
merged 8 commits into from
Jun 19, 2019

Conversation

martijnvg
Copy link
Member

This commit replaces usages of Streamable with Writeable for the
SingleShardRequest / TransportSingleShardAction classes and subclasses of
these classes.

Note that where possible response fields were made final and default
constructors were removed.

Relates to #34389

This commit replaces usages of Streamable with Writeable for the
SingleShardRequest / TransportSingleShardAction classes and subclasses of
these classes.

Note that where possible response fields were made final and default
constructors were removed.

Relates to elastic#34389
@martijnvg martijnvg added >non-issue :Core/Infra/Core Core issues without another label v8.0.0 v7.3.0 labels Jun 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


/**
/**˜
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra ˜

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/bwc

@martijnvg
Copy link
Member Author

@elasticmachine run elasticsearch-ci/2

@martijnvg martijnvg merged commit 99495aa into elastic:master Jun 19, 2019
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Jun 19, 2019
…lastic#43222)

Backport of: elastic#43222

This commit replaces usages of Streamable with Writeable for the
SingleShardRequest / TransportSingleShardAction classes and subclasses of
these classes.

Note that where possible response fields were made final and default
constructors were removed.

Relates to elastic#34389
martijnvg added a commit that referenced this pull request Jun 19, 2019
…43222) (#43364)

Backport of: #43222

This commit replaces usages of Streamable with Writeable for the
SingleShardRequest / TransportSingleShardAction classes and subclasses of
these classes.

Note that where possible response fields were made final and default
constructors were removed.

Relates to #34389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants