Add trace logging when SSLService is set #42210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something is causing this to be set twice in LicenseTribeTests. These tribe tests do weird things to work around the SetOnce that XPackPlugin uses for the SslService, but that seems to be failing randomly. This additional logging will help work out which plugin instance is setting the SSLService when it should not be. Relates: elastic#42004
tvernum
added
>test
|
Pinging @elastic/es-security |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
May 21, 2019
Something is causing this to be set twice in LicenseTribeTests. These tribe tests do weird things to work around the SetOnce that XPackPlugin uses for the SslService, but that seems to be failing randomly. This additional logging will help work out which plugin instance is setting the SSLService when it should not be. Relates: elastic#42004 Backport of: elastic#42210
tvernum
added a commit
that referenced
this pull request
May 21, 2019
Something is causing this to be set twice in LicenseTribeTests. These tribe tests do weird things to work around the SetOnce that XPackPlugin uses for the SslService, but that seems to be failing randomly. This additional logging will help work out which plugin instance is setting the SSLService when it should not be. Relates: #42004 Backport of: #42210
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
May 24, 2019
This test is failing on RHEL8, additional logging will help track down the cause. Relates: elastic#42216, elastic#42210
tvernum
added a commit
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something is causing this to be set twice in LicenseTribeTests.
These tribe tests do weird things to work around the SetOnce that
XPackPlugin uses for the SslService, but that seems to be failing
randomly.
This additional logging will help work out which plugin instance is
setting the SSLService when it should not be.
Relates: #42004