[ML] properly nesting objects in document source (#41901) #42077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working through use-cases, I found it impossible to push data to a
range
type field mapping. This was because we were not properly nesting documents in the JSON we are pushing to the index.This change creates objects in the document source itself. This has two major benefits:
Example use case that is enabled with this change:
This will result in an index where range queries are possible to determine which clients accessed the website over a given range.
Implementation details:
group_by
fields as I could not think of a use case for it. The mapping created still treats the fields as an object (machine
in the above use case), the document source just does not show it as plainly. I could be convinced otherwise :)Backport of #41901