Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling of MockLogAppender.PatternSeenEventExpectation #41893

Merged
merged 1 commit into from
May 7, 2019

Conversation

romseygeek
Copy link
Contributor

The class was called PatternSeenEventExcpectation. This commit
is a straight class rename to correct the spelling.

@romseygeek romseygeek added >non-issue :Core/Infra/Logging Log management and logging utilities v8.0.0 v7.2.0 labels May 7, 2019
@romseygeek romseygeek self-assigned this May 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, that's embarrassing. Thanks for fixing it. LGTM.

@romseygeek
Copy link
Contributor Author

I blame the new Macbook keyboards :)

@romseygeek romseygeek merged commit 502b395 into elastic:master May 7, 2019
romseygeek added a commit that referenced this pull request May 7, 2019
The class was called PatternSeenEventExcpectation. This commit
is a straight class rename to correct the spelling.
@jasontedor
Copy link
Member

That is in fact a good default excuse. 😇

jasontedor pushed a commit that referenced this pull request May 7, 2019
The class was called PatternSeenEventExcpectation. This commit
is a straight class rename to correct the spelling.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 7, 2019
* elastic/master: (50 commits)
  Cleanup versioned deprecations in analysis (elastic#41560)
  Allow unknown task time in QueueResizingEsTPE (elastic#41810)
  SQL: Remove CircuitBreaker from parser (elastic#41835)
  [DOCS] Fix callouts for dataframe APIs (elastic#41904)
  Handle serialization exceptions during publication (elastic#41781)
  Correct spelling of MockLogAppender.PatternSeenEventExpectation (elastic#41893)
  Update TLS ciphers and protocols for JDK 11 (elastic#41808)
  Remove Harmful Exists Check from BlobStoreFormat (elastic#41898)
  Fix fractional seconds for strict_date_optional_time (elastic#41871)
  Remove op.name configuration setting (elastic#41445)
  Reject port ranges in `discovery.seed_hosts` (elastic#41404)
  [ML-DataFrame] migrate to PageParams for get and stats, move PageParams into core (elastic#41851)
  Reenable RareClusterStateIT Mapping Propagation Tests (elastic#41884)
  [DOCS] Rewrite `exists` query docs (elastic#41868)
  Revert "Mute MinimumMasterNodesIT.testThreeNodesNoMasterBlock()"
  [DOCS] Fix typo referring to multi search API
  Provide names for all artifact repositories (elastic#41857)
  Move InternalAggregations to Writeable (elastic#41841)
  Fix compilation after incorrect merge
  Unmute TestClustersPluginIT.testMultiNode (elastic#41340)
  ...
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
…tic#41893)

The class was called PatternSeenEventExcpectation. This commit
is a straight class rename to correct the spelling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants