Fix minor watcher bug, unmute test, add additional debug logging #41765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unmutes the org.elasticsearch.smoketest.SmokeTestWatcherWithSecurityIT test suite, fixes a bug [1] that was introduced while the test was muted, and adds some additional debug logging, and enables debug for the ES instance used in this Watcher test. The bug fixed here is minor and unlikely to happen. It requires ES to be started with ILM disabled, Watcher enabled, and Watcher explicitly stopped and restarted. Due to validation Watcher does not fully start and can result in a partially started state. This is an unlikely scenerio outside of the testing framework. Optimistically closing the following Fixes elastic#35361 Fixes elastic#30777 Fixes elastic#35361 Fixes elastic#33291 Fixes elastic#29893 If this does not fully fix the issue, there will now be better debug logging.
|
@elasticmachine run elasticsearch-ci/1 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/1 |
|
Pinging @elastic/es-core-features |
If the watch fires just AFTER the index is deleted it will result in an error I caught one with debug logging: [2019-05-07T15:26:44,201][DEBUG][o.e.x.w.e.ExecutionService] [node-0] finished [ZAnGKoyZHxTusFvJEUlA]/[ZAnGKoyZHxTusFvJEUlA_1d7a8f92-1ea8-4cd8-a0a1-17d186f9ebae-2019-05-07T20:26:43.370979Z] [2019-05-07T15:26:44,384][INFO ][o.e.c.m.MetaDataDeleteIndexService] [node-0] [my_test_index/G9D7pS17SzCI9oJwmvOJZg] deleting index <-- THIS IS THE START OF THE @after [2019-05-07T15:26:44,398][DEBUG][o.e.x.w.t.s.e.TickerScheduleTriggerEngine] [node-0] triggered job [ZAnGKoyZHxTusFvJEUlA] at [2019-05-07T20:26:44.398Z] (scheduled time was [2019-05-07T20:26:44.017Z]) <--- TRIGGERED DURING THE SHUTDOWN [2019-05-07T15:26:44,451][DEBUG][o.e.x.w.e.ExecutionService] [node-0] executing watch [ZAnGKoyZHxTusFvJEUlA] [2019-05-07T15:26:44,459][DEBUG][o.e.a.s.TransportSearchAction] [node-0] All shards failed for phase: [query]
|
closing this PR to separate concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unmutes the org.elasticsearch.smoketest.SmokeTestWatcherWithSecurityIT
test suite, fixes a bug [1] that was introduced while the test was muted, and
adds some additional debug logging, and enables debug for the ES instance used
in this Watcher test.
The bug fixed here is minor and unlikely to happen. It requires ES to be started
with ILM disabled, Watcher enabled, and Watcher explicitly stopped and restarted.
Due to validation Watcher does not fully start and can result in a partially started
state. This is an unlikely scenerio outside of the testing framework.
Optimistically closing the following
Fixes #35361
Fixes #30777
Fixes #35361
Fixes #33291
Fixes #29893
If this does not fully fix the test failures for this class, there will now be better debug logging.