Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum forecast interval to 10 years. #41082

Merged
merged 3 commits into from
Apr 11, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Apr 10, 2019

Increase maximum forecast interval from 8 weeks (56 days) to ~10 years (3650 days).
Add a YML test for the validation being modified.

Closes #41103

@przemekwitek przemekwitek added :ml Machine learning v8.0.0 labels Apr 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek przemekwitek force-pushed the maximum_forecast_interval branch from d753e78 to 49b7991 Compare April 10, 2019 17:56
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM technically, we should ensure the kibana change lands on the same version if this goes in

@droberts195
Copy link
Contributor

we should ensure the kibana change lands on the same version if this goes in

That's a nice-to-have, but not critical. We can build up the layers as time goes by.

@przemekwitek przemekwitek merged commit 891844f into elastic:master Apr 11, 2019
@przemekwitek przemekwitek deleted the maximum_forecast_interval branch April 11, 2019 20:23
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request May 30, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek added a commit that referenced this pull request May 30, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request May 30, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek added a commit that referenced this pull request May 31, 2019
Increase the maximum duration to ~10 years (3650 days).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Extend ML Forecast beyond 8 weeks in the REST API
6 participants