Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Add usage mapping for monitoring-kibana index #40899

Merged
merged 1 commit into from
Apr 5, 2019
Merged

[Monitoring] Add usage mapping for monitoring-kibana index #40899

merged 1 commit into from
Apr 5, 2019

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Apr 5, 2019 •
edited
Loading

Needed for this PR elastic/kibana#34609, Since we will start filtering if this field exists.

Context: elastic/kibana#32519

CC @chrisronline

@Bamieh Bamieh marked this pull request as ready for review April 5, 2019 14:12
tsullivan
tsullivan approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan
Copy link
Member

I tested a build off this branch and verified that filtering for usage data works with this:
image

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

chrisronline
chrisronline approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bamieh Bamieh merged commit 25c1d81 into master Apr 5, 2019
@Bamieh Bamieh deleted the add-usage-property branch April 5, 2019 17:41
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 6, 2019
@jasontedor
Merge branch 'master' into build-flavor-type-leniency
cad967f 
* master: (63 commits)
  Suppress lease background sync failures if stopping (elastic#40902)
  [DOCS] Added settings page for ILM. (elastic#40880)
  [Docs] Remove extraneous text (elastic#40914)
  Move test classes to test root in Painless (elastic#40873)
  Fix date index name processor default date_formats (elastic#40915)
  Source additional files correctly in elasticsearch-cli (elastic#40890)
  Allow AVX-512 on JDK 11+ (elastic#40828)
  [Docs] Change example to show col headers (elastic#40822)
  Update apache httpclient to version 4.5.8 (elastic#40875)
  Update monitoring-kibana.json (elastic#40899)
  Introduce Delegating ActionListener Wrappers (elastic#40129)
  Deprecate old transport settings (elastic#40821)
  Add Kibana application privileges for monitoring and ml reserved roles (elastic#40651)
  Use Writeable for TransportReplAction derivatives (elastic#40894)
  Add test for HTTP and Transport TLS on basic license (elastic#40714)
  Remove unneded cluster config from test (elastic#40856)
  Make Fuzziness reject illegal values earlier (elastic#33511)
  Remove test-only customisation from TransReplAct (elastic#40863)
  Fix dense/sparse vector limit documentation (elastic#40852)
  Make -try xlint warning disabled by default. (elastic#40833)
  ...
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 6, 2019
@jasontedor
Merge branch 'master' into minimum-java-11
889cf14 
* master: (77 commits)
  Suppress lease background sync failures if stopping (elastic#40902)
  [DOCS] Added settings page for ILM. (elastic#40880)
  [Docs] Remove extraneous text (elastic#40914)
  Move test classes to test root in Painless (elastic#40873)
  Fix date index name processor default date_formats (elastic#40915)
  Source additional files correctly in elasticsearch-cli (elastic#40890)
  Allow AVX-512 on JDK 11+ (elastic#40828)
  [Docs] Change example to show col headers (elastic#40822)
  Update apache httpclient to version 4.5.8 (elastic#40875)
  Update monitoring-kibana.json (elastic#40899)
  Introduce Delegating ActionListener Wrappers (elastic#40129)
  Deprecate old transport settings (elastic#40821)
  Add Kibana application privileges for monitoring and ml reserved roles (elastic#40651)
  Use Writeable for TransportReplAction derivatives (elastic#40894)
  Add test for HTTP and Transport TLS on basic license (elastic#40714)
  Remove unneded cluster config from test (elastic#40856)
  Make Fuzziness reject illegal values earlier (elastic#33511)
  Remove test-only customisation from TransReplAct (elastic#40863)
  Fix dense/sparse vector limit documentation (elastic#40852)
  Make -try xlint warning disabled by default. (elastic#40833)
  ...
@Bamieh Bamieh mentioned this pull request Apr 24, 2019
Merged
@pickypg
Copy link
Member

pickypg commented Apr 26, 2019

Was this backported to 7.x, 7.0, and 6.7?

pickypg pushed a commit to pickypg/elasticsearch that referenced this pull request Apr 26, 2019
@Bamieh @pickypg
Update monitoring-kibana.json (elastic#40899)
19df7fe
pickypg added a commit to pickypg/elasticsearch that referenced this pull request Apr 26, 2019
@pickypg
[7.x] [Monitoring] Add usage mapping for monitoring-kibana index (e…
d5cba7b 
…lastic#40899)

Backports the usage change to 7.x (and 7.0). A separate backport is needed to
change the version for 6.7, which will complete this backport.
@pickypg pickypg mentioned this pull request Apr 26, 2019
Merged
pickypg pushed a commit to pickypg/elasticsearch that referenced this pull request Apr 26, 2019
@Bamieh @pickypg
Update monitoring-kibana.json (elastic#40899)
573788b
@pickypg pickypg mentioned this pull request Apr 26, 2019
Merged
pickypg added a commit to pickypg/elasticsearch that referenced this pull request Apr 26, 2019
@pickypg
[7.0] [Monitoring] Add usage mapping for monitoring-kibana index (e…
40f39ce 
…lastic#40899)

Backports the usage change to 7.0. A separate backport is needed to
change the version for 6.7, which will complete this backport.
@pickypg pickypg mentioned this pull request Apr 26, 2019
Merged
pickypg added a commit that referenced this pull request Apr 26, 2019
@pickypg
[7.x] [Monitoring] Add usage mapping for monitoring-kibana index (…
858e7f4 
…#40899) (#41601)

Backports the usage change to 7.x. A separate backport is needed to
change the version for 6.7, which will complete this backport.
pickypg added a commit that referenced this pull request Apr 26, 2019
@pickypg
[7.0] [Monitoring] Add usage mapping for monitoring-kibana index (#…
94211dc 
…40899) (#41602)

Backports the usage change to 7.0. A separate backport is needed to
change the version for 6.7, which will complete this backport.
@pickypg
Copy link
Member

pickypg commented Apr 26, 2019

Backports:

7.x / 7.1: #41601 / 858e7f4
7.0: #41602 / 94211dc
6.7: #41606 / 31c49ff

pickypg added a commit that referenced this pull request Apr 26, 2019
@pickypg
[6.7] [Monitoring] Add usage mapping for monitoring-kibana index (#…
31c49ff 
…40899) (#41606)

Backports the usage change to 6.7.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@Bamieh
Update monitoring-kibana.json (elastic#40899)
4a75ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
:Data Management/Monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Bamieh @tsullivan @elasticmachine @pickypg @chrisronline @polyfractal