Remove string usages of old transport settings #40818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#36652. We intend to deprecate a number of transport settings in 7.x and remove them in 8.0. This commit removes the string usages of these settings.
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
|
This commit will go to 7.1 and 8.0. There should not be any backwards compatibility issues because the new settings are on 6.7. |
6 tasks
ywelsch
suggested changes
Apr 4, 2019
| @@ -537,7 +537,7 @@ private void createConfiguration() { | |||
| defaultConfig.put("node.attr.testattr", "test"); | |||
| defaultConfig.put("node.portsfile", "true"); | |||
| defaultConfig.put("http.port", "0"); | |||
| defaultConfig.put("transport.tcp.port", "0"); | |||
| defaultConfig.put("transport.port", "0"); | |||
There was a problem hiding this comment.
do we need to conditionally set this based on version as well?
| @@ -60,7 +60,7 @@ node${attr}.dummy: everyone_has_me | |||
| node${attr}.number: ${node:1} | |||
| node${attr}.array: [${node:0:1}, ${node:1}] | |||
| http.port: ${http_port} | |||
| transport.tcp.port: ${transport_port} | |||
| transport.port: ${transport_port} | |||
There was a problem hiding this comment.
this script runs old versions of elasticsearch (2.0.0, 5.0.0, 6.0.0) so should not be updated
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 5, 2019
* elastic/master: (36 commits) Remove unneded cluster config from test (elastic#40856) Make Fuzziness reject illegal values earlier (elastic#33511) Remove test-only customisation from TransReplAct (elastic#40863) Fix dense/sparse vector limit documentation (elastic#40852) Make -try xlint warning disabled by default. (elastic#40833) Async Snapshot Repository Deletes (elastic#40144) Revert "Replace usages RandomizedTestingTask with built-in Gradle Test (elastic#40564)" Init global checkpoint after copy commit in peer recovery (elastic#40823) Replace usages RandomizedTestingTask with built-in Gradle Test (elastic#40564) [DOCS] Removed redundant (not quite right) information about upgrades. Remove string usages of old transport settings (elastic#40818) Rollup ignores time_zone on date histogram (elastic#40844) HLRC: fix uri encode bug when url path starts with '/' (elastic#34436) Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata Docs: Pin two IDs in the rest client (elastic#40785) Adds version 6.7.2 [DOCS] Remind users to include @ symbol when applying license file (elastic#40688) HLRC: Convert xpack methods to client side objects (elastic#40705) Allow ILM to stop if indices have nonexistent policies (elastic#40820) Add an OpenID Connect authentication realm (elastic#40674) ...
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Apr 15, 2019
This is related to elastic#36652. We intend to deprecate a number of transport settings in 7.x and remove them in 8.0. This commit removes the string usages of these settings.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This is related to elastic#36652. We intend to deprecate a number of transport settings in 7.x and remove them in 8.0. This commit removes the string usages of these settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #36652. We intend to deprecate a number of transport
settings in 7.x and remove them in 8.0. This commit removes the string
usages of these settings.