Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Xlint exclusions in all plugins. #40721

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Remove -Xlint exclusions in all plugins. #40721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d87bf83
Remove -Xlint exclusions in all plugins.
martijnvg Apr 2, 2019
daf01fc
Merge remote-tracking branch 'es/master' into remove_xlint_suppressio…
martijnvg Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions plugins/ingest-attachment/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ dependencies {
compile "org.apache.james:apache-mime4j-dom:${versions.mime4j}"
}

// TODO: stop using LanguageIdentifier...
compileJava.options.compilerArgs << "-Xlint:-deprecation"


dependencyLicenses {
mapping from: /apache-mime4j-.*/, to: 'apache-mime4j'
}
Expand Down
1 change: 1 addition & 0 deletions ...est-attachment/src/main/java/org/elasticsearch/ingest/attachment/AttachmentProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public IngestDocument execute(IngestDocument ingestDocument) {
}

if (properties.contains(Property.LANGUAGE) && Strings.hasLength(parsedContent)) {
// TODO: stop using LanguageIdentifier...
LanguageIdentifier identifier = new LanguageIdentifier(parsedContent);
String language = identifier.getLanguage();
additionalFields.put(Property.LANGUAGE.toLowerCase(), language);
Expand Down
4 changes: 0 additions & 4 deletions plugins/mapper-size/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,3 @@ esplugin {
description 'The Mapper Size plugin allows document to record their uncompressed size at index time.'
classname 'org.elasticsearch.plugin.mapper.MapperSizePlugin'
}

// TODO: migrate to points
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this todo is no longer relevant, as size field mapper is using points.

compileJava.options.compilerArgs << "-Xlint:-deprecation"
compileTestJava.options.compilerArgs << "-Xlint:-deprecation"
3 changes: 0 additions & 3 deletions plugins/transport-nio/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ esplugin {
hasClientJar = true
}

compileJava.options.compilerArgs << "-Xlint:-try"
compileTestJava.options.compilerArgs << "-Xlint:-rawtypes,-unchecked"

dependencies {
compile "org.elasticsearch:elasticsearch-nio:${version}"

Expand Down
3 changes: 1 addition & 2 deletions plugins/transport-nio/src/main/java/org/elasticsearch/http/nio/NettyAdaptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import java.util.LinkedList;
import java.util.function.BiConsumer;

public class NettyAdaptor implements AutoCloseable {
class NettyAdaptor {

private final EmbeddedChannel nettyChannel;
private final LinkedList<FlushOperation> flushOperations = new LinkedList<>();
Expand Down Expand Up @@ -64,7 +64,6 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
nettyChannel.pipeline().addLast(handlers);
}

@Override
public void close() throws Exception {
assert flushOperations.isEmpty() : "Should close outbound operations before calling close";

Expand Down