WIP for parsing composite patterns with Format.parseObject #40364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
|
Rally results on this PR |
|
rally results from master |
|
master vs PR |
spinscale
reviewed
Mar 25, 2019
| return (TemporalAccessor) object; | ||
| } | ||
| } | ||
| throw new DateTimeParseException("Failed to parse with all parsers from a composite parser", input, 0); |
There was a problem hiding this comment.
it's implicit that this is a composite parser, as the format will be returned in the IAE?
spinscale
reviewed
Mar 25, 2019
| return firstParser().parse(input); | ||
| } | ||
|
|
||
| private boolean parssingSucceeded(Object object, String input, ParsePosition pos) { |
There was a problem hiding this comment.
useless nit: one s less?
pgomulka
force-pushed
the
poc/format_parse_object
branch
from
e979460 to
cf76d67
Compare
Java-time fails parsing composite patterns when first pattern matches only the prefix of the input. It expects pattern in longest-shortest order. Joda does not suffer from this closes elastic#39916
remve unused method typo and message change
pgomulka
force-pushed
the
poc/format_parse_object
branch
from
cf76d67 to
6ac4504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a work in progress now. making sure this would pass all the tests. The performance should be good of this:
relates #40100