-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Snapshot Repository Deletes #40144
Merged
original-brownbear
merged 32 commits into
elastic:master
from
original-brownbear:async-repository-deletes
Apr 5, 2019
Merged
Changes from 13 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
878d731
add threadpool to blobstore repository
original-brownbear 18cd785
async delete api
original-brownbear 05ffbad
still fails
original-brownbear 8f5081e
tests pass
original-brownbear a1b3a8a
tests pass
original-brownbear cdcb7e8
Merge remote-tracking branch 'elastic/master' into async-shard-writes
original-brownbear 305b500
shorter
original-brownbear d27e6c6
add javadoc
original-brownbear dced6df
CR: Comments
original-brownbear 4f8d93d
CR comments
original-brownbear e55226d
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear ae6fb85
add threadpool to internal repo call
original-brownbear 26635c5
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear c24bb71
use generic pool for snapshot restore
original-brownbear b4c21c9
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 585bcbb
CR: add a little doc
original-brownbear 1fd0f83
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 2895f19
CR: chain actions to dry things up a little
original-brownbear 486a31c
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear d045920
dry up logic using callback chain
original-brownbear 6bac7c0
add comment
original-brownbear e1c8162
dry logic up some more
original-brownbear def77dc
dry logic up some more
original-brownbear b0dd8c9
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 4d7c00d
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 0c06525
much simpler
original-brownbear 1f921ee
much simpler
original-brownbear d78b7f0
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 36b2e38
remove comment
original-brownbear a156b70
Merge remote-tracking branch 'elastic/master' into async-repository-d…
original-brownbear 59bdc97
CR comments
original-brownbear c311311
CR comments
original-brownbear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment as to why we use generic instead of snapshot here? (same for TransportRestoreSnapshotAction). Otherwise, someone in the future might just set this back to snapshot.