Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an example in the Set processor documentation to address #30604 #39941

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Adding an example in the Set processor documentation to address #30604 #39941

merged 2 commits into from
Mar 12, 2019

Conversation

ajoshbiol
Copy link
Contributor

Adding an example in the Set processor documentation to address #30604

@talevy talevy self-requested a review March 12, 2019 00:11
@talevy talevy added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Mar 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jtibshirani
Copy link
Contributor

Thanks @ajoshbiol for the PR! It looks like one of the docs tests is failing, because the _type in the response doesn't match. Other than that, this looks good to me (although I'll let @talevy weigh in as well before approving).

@ajoshbiol
Copy link
Contributor Author

Thanks @jtibshirani! I updated the response document type to _doc to pass the builds.

talevy
talevy approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jtibshirani.

looks great! thank you for iterating and contributing
to better documentation!

@talevy talevy merged commit dd01da9 into master Mar 12, 2019
@talevy talevy deleted the set_processor_doc branch March 12, 2019 17:47
@talevy
Copy link
Contributor

talevy commented Mar 12, 2019

thanks @ajoshbiol. I went ahead and merged into master and deleted the branch. I will go forward with backports to 7.0 and 7.x

talevy pushed a commit to talevy/elasticsearch that referenced this pull request Mar 12, 2019
@ajoshbiol @talevy
Adding an example in the Set processor documentation to address elast…
3a04675 
…ic#30604 (elastic#39941)

* Added an example of using set to copy values from one field to another.

* Modified the document type to match the test.
talevy pushed a commit to talevy/elasticsearch that referenced this pull request Mar 12, 2019
@ajoshbiol @talevy
Adding an example in the Set processor documentation to address elast…
1d380ef 
…ic#30604 (elastic#39941)

* Added an example of using set to copy values from one field to another.

* Modified the document type to match the test.
talevy added a commit that referenced this pull request Mar 12, 2019
@talevy
Adding an example in the Set processor documentation to address #30604 (
3896076 
#39941) (#39968)

* Added an example of using set to copy values from one field to another.

* Modified the document type to match the test.
@talevy talevy mentioned this pull request Mar 12, 2019
Closed
talevy added a commit that referenced this pull request Mar 12, 2019
@talevy
Adding an example in the Set processor documentation to address #30604 (
9ab2410 
#39941) (#39969)

* Added an example of using set to copy values from one field to another.

* Modified the document type to match the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talevy talevy talevy approved these changes

Assignees
No one assigned
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ajoshbiol @elasticmachine @jtibshirani @talevy @jakelandis @michaelbaamonde