Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cause to determine if node with primary is closing #39723

Merged
merged 3 commits into from
Mar 6, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Mar 5, 2019

We need to unwrap and use the actual cause when determining if the node
with primary shard is shutting down because TransportService will throw a
TransportException wrapped in a SendRequestTransportException.

Relates #39584

@dnhatn dnhatn added >bug v7.0.0 :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.7.0 v8.0.0 v7.2.0 labels Mar 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn requested a review from ywelsch March 5, 2019 21:46
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Mar 6, 2019

Thanks @ywelsch.

@dnhatn dnhatn merged commit cd9f8cc into elastic:master Mar 6, 2019
@dnhatn dnhatn deleted the primary-shutdown-follow-up branch March 6, 2019 19:59
dnhatn added a commit that referenced this pull request Mar 6, 2019
We need to unwrap and use the actual cause when determining if the node
with primary shard is shutting down because TransportService will throw
a TransportException wrapped in a SendRequestTransportException.

Relates #39584
dnhatn added a commit that referenced this pull request Mar 6, 2019
We need to unwrap and use the actual cause when determining if the node
with primary shard is shutting down because TransportService will throw
a TransportException wrapped in a SendRequestTransportException.

Relates #39584
dnhatn added a commit that referenced this pull request Mar 6, 2019
We need to unwrap and use the actual cause when determining if the node
with primary shard is shutting down because TransportService will throw
a TransportException wrapped in a SendRequestTransportException.

Relates #39584
dnhatn added a commit that referenced this pull request Mar 7, 2019
We need to unwrap and use the actual cause when determining if the node
with primary shard is shutting down because TransportService will throw
a TransportException wrapped in a SendRequestTransportException.

Relates #39584
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 7, 2019
* 6.7:
  Fix CCR HLRC docs
  Introduce forget follower API (elastic#39718)
  6.6.2 release notes.
  Update release notes for 6.7.0
  Add documentation for min_hash filter (elastic#39671)
  Unmute testIndividualActionsTimeout
  Unmute testFollowIndexAndCloseNode
  Use unwrapped cause to determine if node is closing (elastic#39723)
  Don’t ack if unable to remove failing replica (elastic#39584)
  Wipe Snapshots Before Indices in RestTests (elastic#39662) (elastic#39765)
  Bug fix for AnnotatedTextHighlighter (elastic#39525)
  Fix Snapshot BwC with Version 5.6.x (elastic#39737)
  Fix occasional SearchServiceTests failure (elastic#39697)
  Correct date in daterange-aggregation.asciidoc (elastic#39727)
  Add a note to purge the ingest-geoip plugin (elastic#39553)
kovrus added a commit to crate/crate that referenced this pull request Aug 29, 2019
kovrus added a commit to crate/crate that referenced this pull request Aug 29, 2019
kovrus added a commit to crate/crate that referenced this pull request Sep 4, 2019
kovrus added a commit to crate/crate that referenced this pull request Sep 4, 2019
kovrus added a commit to crate/crate that referenced this pull request Sep 4, 2019
mergify bot pushed a commit to crate/crate that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.6.3 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants