Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocation.asciidoc - match description with example. #39606

Merged
merged 1 commit into from
Mar 20, 2019
Merged

allocation.asciidoc - match description with example. #39606

merged 1 commit into from
Mar 20, 2019

Conversation

aladdam
Copy link
Contributor

@aladdam aladdam commented Mar 2, 2019

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@matriv matriv mentioned this pull request Mar 4, 2019
Closed
@matriv matriv added >docs General docs changes :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Mar 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@javanna
Copy link
Member

javanna commented Mar 18, 2019

hi @aladdam thanks for opening this PR, the fix makes sense to me. Would you mind signing our CLA so we can merge this in?

@aladdam
Copy link
Contributor Author

aladdam commented Mar 20, 2019

hi @aladdam thanks for opening this PR, the fix makes sense to me. Would you mind signing our CLA so we can merge this in?

hi @javanna Thanks. Completed it.

@javanna
Copy link
Member

javanna commented Mar 20, 2019

jenkins test this please

@javanna javanna merged commit 459c101 into elastic:6.6 Mar 20, 2019
@javanna javanna changed the title allocation.assiidoc - match description with example. allocation.asciidoc - match description with example. Mar 20, 2019
@javanna
Copy link
Member

javanna commented Mar 20, 2019

thanks @aladdam !

@javanna javanna added the v6.7.1 label Mar 22, 2019
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 25, 2019
@aladdam @javanna
[DOCS] match description with example in allocation docs page (elasti…
5dcf8a6 
…c#39606)
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 25, 2019
@aladdam @javanna
[DOCS] match description with example in allocation docs page (elasti…
d604ae9 
…c#39606)
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 25, 2019
@aladdam @javanna
[DOCS] match description with example in allocation docs page (elasti…
d819e19 
…c#39606)
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 29, 2019
@aladdam @javanna
[DOCS] match description with example in allocation docs page (elasti…
078bc01 
…c#39606)
@javanna javanna mentioned this pull request Mar 29, 2019
Closed
javanna pushed a commit that referenced this pull request Mar 29, 2019
@aladdam @javanna
[DOCS] match description with example in allocation docs page (#39606)
f7e3f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes v6.6.3 v6.7.1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aladdam @elasticmachine @javanna @jakelandis @matriv