Shortcut counts on exists queries #39570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>enhancement
WIP
:Search/Search
|
Pinging @elastic/es-search |
cbuescher
commented
Mar 1, 2019
server/src/test/java/org/elasticsearch/search/query/QueryPhaseTests.java
Outdated
Show resolved
Hide resolved
jpountz
requested changes
Mar 1, 2019
server/src/main/java/org/elasticsearch/search/query/TopDocsCollectorContext.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/query/QueryPhaseTests.java
Outdated
Show resolved
Hide resolved
jtibshirani
reviewed
Mar 2, 2019
server/src/main/java/org/elasticsearch/search/query/TopDocsCollectorContext.java
Show resolved
Hide resolved
cbuescher
force-pushed
the
shortCut-Exists-Query-37475
branch
from
068b113 to
efd7457
Compare
|
@jpountz @jtibshirani I added an update and left a question about also handling |
jpountz
requested changes
Mar 4, 2019
server/src/main/java/org/elasticsearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
|
@jpountz I added the null checks, didn't go into adding specific tests for this though because these cases seem to be triggered by the randomization frequently enough. Let me know if there is anything else to add. |
jpountz
approved these changes
Mar 4, 2019
server/src/main/java/org/elasticsearch/search/query/TopDocsCollectorContext.java
Outdated
Show resolved
Hide resolved
jpountz
approved these changes
Mar 4, 2019
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Mar 4, 2019
`TopDocsCollectorContext` can already shortcut hit counts on `match_all` and `term` queries when there are no deletions. This change adds this ability for `exists` queries if the index doesn't have deletions and fields are indexed. Closes elastic#37475
cbuescher
pushed a commit
that referenced
this pull request
Mar 4, 2019
`TopDocsCollectorContext` can already shortcut hit counts on `match_all` and `term` queries when there are no deletions. This change adds this ability for `exists` queries if the index doesn't have deletions and fields are indexed. Closes #37475
|
@jpountz I ported this back to 7.1, do you think it should also go into 7.0? Maybe not is my feeling atm. |
|
I wouldn't push it to 7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopDocsCollectorContextcan already shortcut hit counts onmatch_allandtermqueries when there are no deletions.This change adds this ability for
existsqueries if the index doesn't have deletions and fields are indexed.Closes #37475