Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-Dataframe] Register Data Frame named writables and xcontents #39569

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

davidkyle
Copy link
Member

Register missing Data Frame named writables and move the registration of Data Frame named xcontent objects from the Data Frame plugin to the XPackClientPlugin as is the style of the day.

The DataFrameTransform class was moved to core to facilitate this.

non-issue as unreleased code

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle force-pushed the dataframe-missing-named branch from 818914b to 65bb192 Compare March 2, 2019 16:10
@davidkyle davidkyle merged commit daa86f5 into elastic:master Mar 4, 2019
@davidkyle davidkyle deleted the dataframe-missing-named branch March 4, 2019 09:54
davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants