Enable IndexActionTests and WatcherIndexingListenerTests #38738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/es-core-features |
pgomulka
commented
Feb 11, 2019
| @@ -101,7 +102,7 @@ void setConfiguration(Configuration configuration) { | |||
| @Override | |||
| public Engine.Index preIndex(ShardId shardId, Engine.Index operation) { | |||
| if (isWatchDocument(shardId.getIndexName(), operation.type())) { | |||
| ZonedDateTime now = clock.instant().atZone(ZoneOffset.UTC); | |||
There was a problem hiding this comment.
this was modified in #38514 . possibly in a merge conflict
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 12, 2019
fix tests to use clock in milliseconds precision in watcher code make sure the date comparison in string format is using same formatters some of the code was modified in elastic#38514 possibly because of merge conflicts closes elastic#38581
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 12, 2019
fix tests to use clock in milliseconds precision in watcher code make sure the date comparison in string format is using same formatters some of the code was modified in elastic#38514 possibly because of merge conflicts closes elastic#38581
This was referenced Feb 12, 2019
michaelbaamonde
added
v7.0.0-rc1
>test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tests to use clock in milliseconds precision in watcher code
make sure the date comparison in string format is using same formatters
some of the code was modified in #38514 possibly because of merge conflicts
closes #38581