Minimize USE_ZEN2 setting usage #38200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrershov
added
>test
|
Pinging @elastic/es-distributed |
DaveCTurner
approved these changes
Feb 1, 2019
added 2 commits
February 4, 2019 13:36
|
run elasticsearch-ci/1 |
|
run elasticsearch-ci/2 |
|
run elasticsearch-ci/default-distro |
# Conflicts: # test/framework/src/main/java/org/elasticsearch/test/ESIntegTestCase.java # x-pack/plugin/security/src/test/java/org/elasticsearch/license/LicensingTests.java # x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/transport/ServerTransportFilterIntegrationTests.java
|
These changes were incorporated into #38414 it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all the tests are migrated to Zen2, we want to minimize USE_ZEN2
setting usage, to make it clear that the default value of true is used.
We still have some tests, that make use of
getUseZen2, which is setto true, however, when you look for USE_ZEN2 setting usage, these tests
introduce noise.
This setting should only be used in Zen1IT (which checks the Zen1 -
Zen2 mixed cluster) and in the test framework (and will be completely
removed once Zen1 support is removed).