[ML] Datafeed deprecation checks #37932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Jan 28, 2019
This actually highlights a bug in 6.0-6.6: the deprecation endpoint would not necessarily work in a mixed version cluster containing 5.6.5 plus one of these versions. But what's done is done and nobody has complained so far...
|
The deprecation info endpoint existed throughout the lifetime of 6.x, and if we'd done this for the ML bits too then it would have simplified the BWC wire transport checks. Therefore I will forward port this change to master so we don't have the same problem in 7.last. In the forward port to master some of the tests will become no-ops, as initially there won't be any deprecated search syntax in 7.0. I will put TODOs in these tests to add some deprecated search syntax once something has been deprecated for 8.0. |
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Jan 30, 2019
Deprecation checks for the ML datafeed query and aggregations.
|
The master branch forward port of this is in #38026. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation checks for ml datafeed query and aggregations