Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ccr to xpack usage infrastructure #37256

Merged
merged 13 commits into from
Jan 30, 2019

Conversation

martijnvg
Copy link
Member

Closes #37221

@martijnvg martijnvg added >enhancement v7.0.0 :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.7.0 labels Jan 9, 2019
@martijnvg martijnvg requested review from jasontedor and dnhatn January 9, 2019 10:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ycombinator
Copy link
Contributor

Hi folks, we have a PR in Kibana that's waiting on the functionality in this PR: elastic/kibana#28840. Any chance we could get this reviewed soon? Thanks!

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor nits but LGTM.

@martijnvg
Copy link
Member Author

@dnhatn I made a slight modification to this PR. Instead of returning last_follower_index_creation_date, I change the ccr feature set to return time_since_last_index_followed. I think this is more valuable to return than a timestamp.

@dnhatn
Copy link
Member

dnhatn commented Jan 29, 2019

@martijnvg Yes, the new stat is more valuable 💯. I am fine with time_since_last_index_followed but maybe just call it last_follow_time?

@martijnvg
Copy link
Member Author

@dnhatn I've renamed the field to last_follow_time_in_millis. Also last_follow_time_in_millis will not be reported if there are no follower indices (the returned value wouldn't make sense).

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martijnvg.

@martijnvg martijnvg merged commit f51bc00 into elastic:master Jan 30, 2019
martijnvg added a commit that referenced this pull request Jan 30, 2019
* Added ccr to xpack usage infrastructure

Closes #37221
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 30, 2019
* master: (29 commits)
  Fix limit on retaining sequence number (elastic#37992)
  Docs test fix, wait for shards active.
  Revert "Revert "Documented default values for index follow request parameters. (elastic#37917)""
  Revert "Documented default values for index follow request parameters. (elastic#37917)"
  Ensure date parsing BWC compatibility (elastic#37929)
  SQL: Skip the nested and object field types in case of an ODBC request (elastic#37948)
  Use mappings to format doc-value fields by default. (elastic#30831)
  Give precedence to index creation when mixing typed templates with typeless index creation and vice-versa. (elastic#37871)
  Add classifier to tar.gz in docker compose (elastic#38011)
  Documented default values for index follow request parameters. (elastic#37917)
  Fix fetch source option in expand search phase (elastic#37908)
  Restore a noop _all metadata field for 6x indices (elastic#37808)
  Added ccr to xpack usage infrastructure (elastic#37256)
  Fix exit code for Security CLI tools  (elastic#37956)
  Streamline S3 Repository- and Client-Settings (elastic#37393)
  Add version 6.6.1 (elastic#37975)
  Ensure task metadata not null in follow test (elastic#37993)
  Docs fix - missing callout
  Types removal - deprecate include_type_name with index templates (elastic#37484)
  Handle completion suggestion without contexts
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants