Don't block on peer recovery on the target side #37076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we block using the generic threadpool on the target side until the source side has fully executed the recovery. We still block on the source side executing the recovery in a blocking fashion but there is no reason to block on the target side. This will release generic threads early if there are many concurrent recoveries happen. Relates to elastic#36195
s1monw
added
>enhancement
:Distributed Indexing/Recovery
|
Pinging @elastic/es-distributed |
ywelsch
suggested changes
Jan 3, 2019
server/src/main/java/org/elasticsearch/indices/recovery/PeerRecoveryTargetService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/indices/recovery/PeerRecoveryTargetService.java
Outdated
Show resolved
Hide resolved
DaveCTurner
reviewed
Jan 3, 2019
server/src/main/java/org/elasticsearch/indices/recovery/PeerRecoveryTargetService.java
Show resolved
Hide resolved
|
@DaveCTurner @ywelsch I pushed changes |
|
folks I added back the cancelableThreads for now, I am not 100% convinced it's not needed and I would like to investigate it in a followup. I will also try to remove it entirely from the |
ywelsch
approved these changes
Jan 3, 2019
s1monw
added a commit
that referenced
this pull request
Jan 4, 2019
Today we block using the generic thread-pool on the target side until the source side has fully executed the recovery. We still block on the source side executing the recovery in a blocking fashion but there is no reason to block on the target side. This will release generic threads early if there are many concurrent recoveries happen. Relates to #36195
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 11, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 11, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 12, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 12, 2019
kovrus
added a commit
to crate/crate
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we block using the generic thread-pool on the target side
until the source side has fully executed the recovery. We still
block on the source side executing the recovery in a blocking fashion
but there is no reason to block on the target side. This will
release generic threads early if there are many concurrent recoveries
happen.
Relates to #36195