Core: Deprecate negative epoch timestamps #36793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative timestamps are currently supported in joda time. These are dates before epoch. However, it doesn't really make sense to have a negative timestamp, since this is a modern format. Any dates before epoch can be represented with normal date formats, like ISO8601. Additionally, implementing negative epoch timestamp parsing in java time has an edge case which would more than double the code required. This commit deprecates use of negative epoch timestamps.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jasontedor
reviewed
Dec 18, 2018
| @@ -262,49 +262,6 @@ public void testThatEpochsCanBeParsed() { | |||
| assertThat(formatter.parseJoda(epochFloatValue).getMillis(), is(dateTime.getMillis())); | |||
| } | |||
|
|
|||
| public void testThatNegativeEpochsCanBeParsed() { | |||
There was a problem hiding this comment.
Why is this test removed? These would still be parsed by Joda, so would issue deprecation warnings? Or am I misunderstanding something?
There was a problem hiding this comment.
I added it back with a warning check in efd290b
|
@elasticmachine test this please |
|
@elasticmachine test this please |
rjernst
added a commit
that referenced
this pull request
Dec 20, 2018
Negative timestamps are currently supported in joda time. These are dates before epoch. However, it doesn't really make sense to have a negative timestamp, since this is a modern format. Any dates before epoch can be represented with normal date formats, like ISO8601. Additionally, implementing negative epoch timestamp parsing in java time has an edge case which would more than double the code required. This commit deprecates use of negative epoch timestamps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative timestamps are currently supported in joda time. These are
dates before epoch. However, it doesn't really make sense to have a
negative timestamp, since this is a modern format. Any dates before
epoch can be represented with normal date formats, like ISO8601.
Additionally, implementing negative epoch timestamp parsing in java time
has an edge case which would more than double the code required. This
commit deprecates use of negative epoch timestamps.