-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rollup] Validate timezones based on rules not string comparision #36237
Merged
Merged
Changes from 8 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
9037c4a
[Rollup] Compare timezones based on rules not string comparision
polyfractal cc6563e
Fix timestamps in test
polyfractal 4867d99
Use ZoneId
polyfractal 1ef04f0
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal da7ebe3
Fix test
polyfractal 21a38f5
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal aadf68b
Deprecation warnings when using obsolete timezones
polyfractal 38ca541
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal ef0f695
Switch DateHistoConfig over to ZoneId
polyfractal d41dda4
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal d049fea
Test fix: searching the wrong index
polyfractal e9f42ef
checkstyle
polyfractal 1f7802f
ML needs to use zones instead of strings too
polyfractal 5a2cac4
Revert "Switch DateHistoConfig over to ZoneId"
polyfractal 72a1bed
Fix rule matching
polyfractal 94abbeb
Add test for TZ validation in action
polyfractal d573aef
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal feba7e5
Yml test version updates
polyfractal 9f4aada
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal de22b2f
Remove last traces of Joda
polyfractal b88091b
Do not set timezone on rollup request histo
polyfractal d80e035
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal 83bf9bf
Merge remote-tracking branch 'origin/master' into rollup_obsolete_tz
polyfractal fbda167
checkstyle
polyfractal 8822afd
Fix tests, make more realistic
polyfractal a9f2911
Remove unnecessary changes
polyfractal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
ZoneId.of("UTC")
(as this effectively does) causes printing using formats with this ZoneId to be messed up. They will get a[UTC]
appended to the end of the time, like1970-01-02T10:17:36.789Z[UTC]
. Instead, useZoneOffset.UTC
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh, yeah not what was intended. Fixing, thanks!