Make TcpTransport#openConnection fully async
#36095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
|
@DaveCTurner This is another step towards the |
s1monw
approved these changes
Nov 30, 2018
| * This class represents a pending {@link Connection}. It provides the ability to cancel the pending | ||
| * connection and close the underling list of {@link TcpChannel}. | ||
| */ | ||
| final class PendingConnection { |
There was a problem hiding this comment.
maybe we can just return a Releasable instead and document it's purpose?
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Nov 30, 2018
This is a follow-up to elastic#35144. That commit made the underlying connection opening process in TcpTransport asynchronous. However the method still blocked on the process being complete before returning. This commit moves the blocking to the ConnectionManager level. This is another step towards the top-level TransportService api being async.
Tim-Brooks
added a commit
that referenced
this pull request
Nov 30, 2018
This is a follow-up to #35144. That commit made the underlying connection opening process in TcpTransport asynchronous. However the method still blocked on the process being complete before returning. This commit moves the blocking to the ConnectionManager level. This is another step towards the top-level TransportService api being async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #35144. That commit made the underlying
connection opening process in
TcpTransportasynchronous. However themethod still blocked on the process being complete before returning.
This commit moves the blocking to the
ConnectionManagerlevel. This isanother step towards the top-level
TransportServiceapi being async.