Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search as you type field type #35548

Closed

Conversation

andyb-elastic
Copy link
Contributor

This is a WIP - both the implementation and names of the field types

This adds a field type for suggestions using postings. The top level field is terms based and analyzed according to the user's settings. The same content is indexed into these subfields: (1) a subfield wrapped with edge_ngrams, (2) for each shingle size 2..max single size, a subfield wrapped with a shingle filter, and (3) for each shingle size 2.. max shingle size, a subfield wrapped with a shingle filter and edge_ngrams

Jim's original implementation in the server project is still here for reference

@andyb-elastic andyb-elastic added >feature :Search Relevance/Suggesters "Did you mean" and suggestions as you type labels Nov 14, 2018
@andyb-elastic andyb-elastic requested a review from jimczi November 14, 2018 15:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86 colings86 added the WIP label Nov 14, 2018
max shingles = 3 by default, and min gram and max gram are no longer
configurable
@andyb-elastic
Copy link
Contributor Author

I'm replacing this PR with #35600 because we want to use feature-search-as-you-type for the name of the feature branch in this repo, so I renamed the branch I'm merging in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Search Relevance/Suggesters "Did you mean" and suggestions as you type WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants