Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Invalidate Token API #35388
Enhance Invalidate Token API #35388
Changes from 17 commits
71447cc
c9b1c45
dee9fce
f1cbe27
118ed35
a6e1f22
485cff9
0647a28
94abc3f
a2227ea
19c75c4
c3e67f6
8e4dec5
1005e15
2a37cfc
d6cf150
40feb13
75c1f37
4a76b77
43127b0
0055ba1
d7c1556
541bf64
46fca25
ac3dd86
be3cad3
a2d8078
8342818
5c28353
fd5ea5f
e402d88
dac7823
9c8e90c
a8c9410
0f2f201
6209deb
2fb24d6
2e0cf31
e91e555
6ad0850
bbbd900
bcac7f1
bf9043a
162ea66
7356dd2
75e62d6
1c7c761
858935e
e0546b3
ff775e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my earlier comment I don't understand the use of a
Result
object inside aResponse
object.It's more strange in the Rest client, but I don't follow it here either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Result object was created so that I can efficiently pass status between invalidation attempts in TokenService. Then, since I had that encapsulation in the result object, it made sense to use that object in the Response. This didn't feel strange (neither does it now), I thought it follows the paradigm we use with i.e.
User
objects inGetUsers
orRoleDescriptor
objects inGetRoles
(granted we have multiple objects there but one result here ).That said I don't have any objection to not use it in the response if you feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - I get it now.
I'll come back when I've finished reading the token service changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attemptCount maybe since its final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space between
(
and{