HLRC for _mtermvectors #35266
HLRC for _mtermvectors #35266
Conversation
relates to elastic#27205
|
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Great work! Im approving so i dont need to be pinged again, but I just want to make sure you follow up with @jtibshirani WRT the _type stuff
| @@ -197,6 +220,9 @@ public boolean getRealtime() { | |||
| @Override | |||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException { | |||
| builder.startObject(); | |||
| builder.field("_index", index); | |||
| builder.field("_type", type); | |||
There was a problem hiding this comment.
I know @jtibshirani has done some work on removing types from 7.0, and I dont know how this may or may not be impacted. @jtibshirani does this need to be different at all based on the work you did in #35421 ?
There was a problem hiding this comment.
Thanks for the ping! I don't think we need to worry about it in this PR. We'll do a separate pass through each affected API to add the right deprecations (including the Java HLRC).
| @@ -670,7 +670,6 @@ public void testApiNamingConventions() throws Exception { | |||
| "indices.exists_type", | |||
| "indices.get_upgrade", | |||
| "indices.put_alias", | |||
| "mtermvectors", | |||
| :api: multi-term-vectors | ||
| :request: MultiTermVectorsRequest | ||
| :response: MultiTermVectorsResponse | ||
| -- |
There was a problem hiding this comment.
you can stick things like :tvrequest: TermVectorsRequest in here as well. Of course call it what ever you want :)
relates to #27205, #33447