-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Move CCR overview pages #34918
Conversation
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a question.
@@ -55,8 +55,6 @@ include::index-modules.asciidoc[] | |||
|
|||
include::ingest.asciidoc[] | |||
|
|||
include::ccr/index.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/reference/ccr/index.asciidoc
Outdated
@@ -1,7 +1,7 @@ | |||
[role="xpack"] | |||
[testenv="platinum"] | |||
[[xpack-ccr]] | |||
= Cross-cluster replication | |||
= Replicating data across multiple clusters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what is the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a necessity, but it seemed to align better with the titles of similar sections in the table of contents ("securing", "alerting", "monitoring").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer "Cross-cluster replication". It's easier to discover (grep
, searches, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I've reverted that change.
This reverts commit 12bb64d14d6abbbd2ca21f3ea03276151d49a118.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Related to #34726 and elastic/stack-docs#132
This PR removes the CCR overview pages from the Elasticsearch Reference (since they exist in the Stack Overview here: https://www.elastic.co/guide/en/elastic-stack-overview/master/xpack-ccr.html). It also updates the title of the CCR section so that it aligns with the other titles.