Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small typo in migration-assistance doc #34704

Merged
merged 1 commit into from
Oct 23, 2018
Merged

A small typo in migration-assistance doc #34704

merged 1 commit into from
Oct 23, 2018

Conversation

pgomulka
Copy link
Contributor

typo - missing word be

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

cbuescher
cbuescher reviewed Oct 22, 2018
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting this

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka pgomulka merged commit f91cc13 into master Oct 23, 2018
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 23, 2018
@pgomulka
A small typo in migration-assistance doc (elastic#34704)
0e70911 
typo - missing word "be"
pgomulka added a commit that referenced this pull request Oct 23, 2018
@pgomulka
A small typo in migration-assistance doc (#34704) (#34749)
4ca354d 
typo - missing word "be"
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 23, 2018
@jasontedor
Merge branch 'master' into ccr-docs
f7bbdd1 
* master: (24 commits)
  ingest: better support for conditionals with simulate?verbose (elastic#34155)
  [Rollup] Job deletion should be invoked on the allocated task (elastic#34574)
  [DOCS] .Security index is never auto created (elastic#34589)
  CCR: Requires soft-deletes on the follower (elastic#34725)
  re-enable bwc tests (elastic#34743)
  Empty GetAliases authorization fix (elastic#34444)
  INGEST: Document Processor Conditional (elastic#33388)
  [CCR] Add total fetch time leader stat (elastic#34577)
  SQL: Support pattern against compatible indices (elastic#34718)
  [CCR] Auto follow pattern APIs adjustments (elastic#34518)
  [Test] Remove dead code from ExceptionSerializationTests (elastic#34713)
  A small typo in migration-assistance doc (elastic#34704)
  ingest: processor stats (elastic#34724)
  SQL: Implement IN(value1, value2, ...) expression. (elastic#34581)
  Tests: Add checks to GeoDistanceQueryBuilderTests (elastic#34273)
  INGEST: Rename Pipeline Processor Param. (elastic#34733)
  Core: Move IndexNameExpressionResolver to java time (elastic#34507)
  [DOCS] Force Merge: clarify execution and storage requirements (elastic#33882)
  TESTING.asciidoc fix examples using forbidden annotation (elastic#34515)
  SQL: Implement `CONVERT`, an alternative to `CAST` (elastic#34660)
  ...
kcm pushed a commit that referenced this pull request Oct 30, 2018
@pgomulka @kcm
A small typo in migration-assistance doc (#34704)
468c753 
typo - missing word "be"
@colings86 colings86 deleted the typo-migration-assistance branch May 27, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v6.4.3 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @cbuescher @colings86