Replace Streamable w/ Writeable in RoleDescriptor #34544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces usage of Streamable with Writeable within the RoleDescriptor class (and inner classes). Relates: elastic#34389
tvernum
added
v7.0.0
>refactoring
:Security/Authorization
|
Pinging @elastic/es-security |
nik9000
approved these changes
Oct 17, 2018
| this.privileges = in.readStringArray(); | ||
| this.query = in.readOptionalBytesReference(); | ||
| } | ||
|
|
||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { |
There was a problem hiding this comment.
I tend to move writeTo so it is on the same screen as the reading constructor just so it is easier to eyeball them at the same time.
tvernum
added a commit
that referenced
this pull request
Oct 23, 2018
This commit replaces usage of Streamable with Writeable within the RoleDescriptor class (and inner classes). Relates: #34389
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit replaces usage of Streamable with Writeable within the RoleDescriptor class (and inner classes). Relates: #34389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces usage of Streamable with Writeable within the
RoleDescriptor class (and inner classes).
Relates: #34389