Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistake. #34480

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Fix spelling mistake. #34480

merged 1 commit into from
Oct 15, 2018

Conversation

fonxian
Copy link
Contributor

@fonxian fonxian commented Oct 15, 2018

  • Have you signed the contributor license agreement?
    Yes

  • Have you followed the contributor guidelines?
    Yes

  • If submitting code, have you built your formula locally prior to submission with gradle check?
    Yes

  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
    No

  • If submitting code, have you checked that your submission is for an OS that we support?
    Yes

  • If you are submitting this code for a class then read our policy for that.
    Yes

@nik9000
Copy link
Member

nik9000 commented Oct 15, 2018

I think "iff" here means "if and only if". But I think some other folks have bumped into this and "if" works here as well. So I'll merge it so no one else has to wonder.

@nik9000 nik9000 added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Oct 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000 nik9000 merged commit 4e1d7ba into elastic:master Oct 15, 2018
@rjernst
Copy link
Member

rjernst commented Oct 15, 2018

It does mean "if and only if". Switching to just "if" changes the meaning.

nik9000 added a commit that referenced this pull request Oct 15, 2018
@nik9000
Copy link
Member

nik9000 commented Oct 15, 2018

It does mean "if and only if". Switching to just "if" changes the meaning.

Yeah, it does change the meaning. Some of us use "iff" much more like mathematicians and others, like me, tend to use words like "otherwise". Either way, lets leave the original author's comments. I had merged this, but then I reverted it.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 15, 2018
* master:
  Do not update number of replicas on no indices (elastic#34481)
  Core: Remove two methods from AbstractComponent (elastic#34336)
  Use RoleRetrievalResult for better caching (elastic#34197)
  Revert "Search: Fix spelling mistake in Javadoc (elastic#34480)"
  Search: Fix spelling mistake in Javadoc (elastic#34480)
  Docs: improve formatting of Query String Query doc page (elastic#34432)
  Tests: Handle epoch date formatters edge cases (elastic#34437)
  Test: Fix running with external cluster
  Fix handling of empty keyword in terms aggregation (elastic#34457)
  [DOCS] Fix tag in SecurityDocumentationIT
  [Monitoring] Add additional necessary mappings for apm-server (elastic#34392)
  SCRIPTING: Move Aggregation Script Context to its own class (elastic#33820)
  MINOR: Remove Deadcode in  ExpressionTermSetQuery (elastic#34442)
  HLRC: Get SSL Certificates API (elastic#34135)
kcm pushed a commit that referenced this pull request Oct 30, 2018
kcm pushed a commit that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants