Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port aggregation parameter requirement changes from master branch #34254

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Port aggregation parameter requirement changes from master branch #34254

merged 1 commit into from
Oct 3, 2018

Conversation

albendz
Copy link
Contributor

@albendz albendz commented Oct 3, 2018

In addition to #33452 for compatibility in 6.x branch before releasing breaking changes to 7.0.

  • unit tests updated
  • Logs in deprecation logger when combine or reduce is not provided
  • Behavior:
  • no combine, no reduce -> log both missing
  • combine, no reduce -> log reduce missing
  • no combine, reduce -> log combine missing
  • combine, reduce -> no additional logs

@albendz albendz mentioned this pull request Oct 3, 2018
Merged
@colings86
Copy link
Contributor

@elasticmachine test this please

colings86
colings86 approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albendz This LGTM, thanks for creating this extra PR. I've kicked off a test run and assuming this run is successful will merge both this and #33452

@colings86 colings86 added the :Analytics/Aggregations Aggregations label Oct 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86 colings86 merged commit 17e47c6 into elastic:6.x Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colings86 colings86 colings86 approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albendz @colings86 @elasticmachine