Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kerberos] Skip unsupported languages for tests #33253

Merged
merged 1 commit into from
Aug 30, 2018
Merged

[Kerberos] Skip unsupported languages for tests #33253

merged 1 commit into from
Aug 30, 2018

Conversation

bizybot
Copy link
Contributor

@bizybot bizybot commented Aug 29, 2018

Ran for all locales in the system to find locales which caused
problems in tests due to incorrect generalized time handling
in SimpleKdcServer.

Closes#33228

[Kerberos] Add unsupported languages for tests
5c63edc 
Ran for all locales in system to find locales which caused
problems in tests due to incorrect generalized time handling
in simple kdc ldap server.

Closes#33228
@bizybot bizybot added >test Issues or PRs that are addressing/adding tests review v7.0.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.4.0 v6.5.0 labels Aug 29, 2018
@bizybot bizybot requested a review from jkakavas August 29, 2018 22:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@bizybot bizybot changed the title [Kerberos] Add unsupported languages for tests [Kerberos] Skip unsupported languages for tests Aug 29, 2018
tvernum
tvernum approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizybot bizybot merged commit 6fd9710 into elastic:master Aug 30, 2018
@bizybot bizybot deleted the fix/33228 branch August 30, 2018 02:08
bizybot added a commit that referenced this pull request Aug 30, 2018
@bizybot
[Kerberos] Add unsupported languages for tests (#33253)
938a99a 
Ran for all locales in system to find locales which caused
problems in tests due to incorrect generalized time handling
in simple kdc ldap server.

Closes#33228
bizybot added a commit that referenced this pull request Aug 30, 2018
@bizybot
[Kerberos] Add unsupported languages for tests (#33253)
98b7f43 
Ran for all locales in system to find locales which caused
problems in tests due to incorrect generalized time handling
in simple kdc ldap server.

Closes#33228
@jaymode jaymode added v6.4.1 and removed v6.4.0 labels Aug 30, 2018
@jaymode
Copy link
Member

jaymode commented Aug 30, 2018

@bizybot I wonder if there is a different way to do this that does not require hardcoding locales. We know there is incorrect generalized time handling in SimpleKdcServer so shouldn't we be able to do something like test how time gets handled and determine if a locale is ok to test with? This way we avoid having to keep updating this list if a new locale is added or there are other locales than what you have on your machine

@bizybot
Copy link
Contributor Author

bizybot commented Aug 30, 2018

Good idea, I will explore that not sure if it will work as some classes like KerberosTime for java is internal class which is used on the server side when exchanging messages with the formatted date. Thanks, Jay.

@jaymode
Copy link
Member

jaymode commented Aug 30, 2018

My suggestion would be to avoid using any sort of internal class but have a method that mimics the problematic behavior

dnhatn added a commit that referenced this pull request Sep 1, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
a6312a5 
* 6.x:
  Mute test watcher usage stats output
  [Rollup] Fix FullClusterRestart test
  TEST: Disable soft-deletes in ParentChildTestCase
  TEST: Disable randomized soft-deletes settings
  Integrates soft-deletes into Elasticsearch (#33222)
  drop `index.shard.check_on_startup: fix` (#32279)
  Fix AwaitsFix issue number
  Mute SmokeTestWatcherWithSecurityIT testsi
  [DOCS] Moves ml folder from x-pack/docs to docs (#33248)
  TEST: mute more SmokeTestWatcherWithSecurityIT tests
  [DOCS] Move rollup APIs to docs (#31450)
  [DOCS] Rename X-Pack Commands section (#33005)
  Fixes SecurityIntegTestCase so it always adds at least one alias (#33296)
  TESTS: Fix Random Fail in MockTcpTransportTests (#33061) (#33307)
  MINOR: Remove Dead Code from PathTrie (#33280) (#33306)
  Fix pom for build-tools (#33300)
  Lazy evaluate java9home (#33301)
  SQL: test coverage for JdbcResultSet (#32813)
  Work around to be able to generate eclipse projects (#33295)
  Different handling for security specific errors in the CLI. Fix for #33230 (#33255)
  [ML] Refactor delimited file structure detection (#33233)
  SQL: Support multi-index format as table identifier (#33278)
  Enable forbiddenapis server java9 (#33245)
  [MUTE] SmokeTestWatcherWithSecurityIT flaky tests
  Add region ISO code to GeoIP Ingest plugin (#31669) (#33276)
  Don't be strict for 6.x
  Update serialization versions for custom IndexMetaData backport
  Replace IndexMetaData.Custom with Map-based custom metadata (#32749)
  Painless: Fix Bindings Bug (#33274)
  SQL: prevent duplicate generation for repeated aggs (#33252)
  TEST: Mute testMonitorClusterHealth
  Fix serialization of empty field capabilities response (#33263)
  Fix nested _source retrieval with includes/excludes (#33180)
  [DOCS] TLS file resources are reloadable (#33258)
  Watcher: Ensure TriggerEngine start replaces existing watches (#33157)
  Ignore module-info in jar hell checks (#33011)
  Fix docs build after #33241
  [DOC] Repository GCS ADC not supported (#33238)
  Upgrade to latest Gradle 4.10  (#32801)
  Fix/30904 cluster formation part2 (#32877)
  Move file-based discovery to core (#33241)
  HLRC: add client side RefreshPolicy (#33209)
  [Kerberos] Add unsupported languages for tests (#33253)
  Watcher: Reload properly on remote shard change (#33167)
  Fix classpath security checks for external tests. (#33066)
  [Rollup] Only allow aggregating on multiples of configured interval (#32052)
  Added deprecation warning for rescore in scroll queries (#33070)
  Apply settings filter to get cluster settings API (#33247)
  [Rollup] Re-factor Rollup Indexer into a generic indexer for re-usability   (#32743)
  HLRC: create base timed request class (#33216)
  HLRC: Use Optional in validation logic (#33104)
  Painless: Add Bindings (#33042)
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 15, 2018
@DaveCTurner
Add Punjabi to unsupported Kerberos locales list
0143ef1 
Relates elastic#33253 and fixes another test failure similar to elastic#33228.
@DaveCTurner DaveCTurner mentioned this pull request Oct 15, 2018
Merged
DaveCTurner added a commit that referenced this pull request Oct 16, 2018
@DaveCTurner
Add Punjabi to unsupported Kerberos locales list (#34440)
67e7464 
Relates #33253 and fixes another test failure similar to #33228.
DaveCTurner added a commit that referenced this pull request Oct 16, 2018
@DaveCTurner
Add Punjabi to unsupported Kerberos locales list (#34440)
06027b9 
Relates #33253 and fixes another test failure similar to #33228.
kcm pushed a commit that referenced this pull request Oct 30, 2018
@DaveCTurner @kcm
Add Punjabi to unsupported Kerberos locales list (#34440)
4209dd5 
Relates #33253 and fixes another test failure similar to #33228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum approved these changes

@jkakavas jkakavas Awaiting requested review from jkakavas

Assignees
No one assigned
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test Issues or PRs that are addressing/adding tests v6.4.1 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bizybot @elasticmachine @jaymode @tvernum @colings86