Fix ShardFollowNodeTask.Status equals and hash code #33189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were broken when fetch exceptions were introduced to the status object but equals and hash code were not updated then. This commit addresses that.
jasontedor
added
>non-issue
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
* ccr: Only fetch mapping updates when necessary (elastic#33182)
|
@dnhatn @martijnvg This ended up being a little sneakier because |
martijnvg
approved these changes
Aug 28, 2018
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 28, 2018
* ccr: Fix ShardFollowNodeTask.Status equals and hash code (elastic#33189) Make soft-deletes settings final (elastic#33172) Only fetch mapping updates when necessary (elastic#33182)
jasontedor
added a commit
that referenced
this pull request
Aug 28, 2018
These were broken when fetch exceptions were introduced to the status object but equals and hash code were not updated then. This commit addresses that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were broken when fetch exceptions were introduced to the status object but equals and hash code were not updated then. This commit addresses that.