-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] fix updating opened jobs scheduled events (#31651) #32881
Merged
benwtrent
merged 5 commits into
elastic:master
from
benwtrent:bug/ml-opened-job-scheduled-events
Aug 17, 2018
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
acc1b56
ML: fix updating opened jobs scheduled events (#31651)
benwtrent 21da6e8
Adding UpdateParamsTests license header
benwtrent 92f37d7
Adding integration test and addressing PR comments
benwtrent ca80b80
addressing test and job names
benwtrent b8dbdf4
Merge branch 'master' into bug/ml-opened-job-scheduled-events
benwtrent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/UpdateParamsTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
package org.elasticsearch.xpack.ml.job.process.autodetect; | ||
|
||
import org.elasticsearch.test.ESTestCase; | ||
import org.elasticsearch.xpack.core.ml.job.config.DetectionRule; | ||
import org.elasticsearch.xpack.core.ml.job.config.JobUpdate; | ||
import org.elasticsearch.xpack.core.ml.job.config.ModelPlotConfig; | ||
import org.elasticsearch.xpack.core.ml.job.config.Operator; | ||
import org.elasticsearch.xpack.core.ml.job.config.RuleCondition; | ||
|
||
import java.util.Arrays; | ||
import java.util.Collections; | ||
import java.util.List; | ||
|
||
|
||
public class UpdateParamsTests extends ESTestCase { | ||
|
||
public void testFromJobUpdate() { | ||
String jobId = "foo"; | ||
DetectionRule rule = new DetectionRule.Builder(Arrays.asList( | ||
new RuleCondition(RuleCondition.AppliesTo.ACTUAL, | ||
Operator.GT, 1.0))).build(); | ||
List<DetectionRule> rules = Arrays.asList(rule); | ||
List<JobUpdate.DetectorUpdate> detectorUpdates = Collections.singletonList( | ||
new JobUpdate.DetectorUpdate(2, null, rules)); | ||
JobUpdate.Builder updateBuilder = new JobUpdate.Builder(jobId) | ||
.setModelPlotConfig(new ModelPlotConfig()) | ||
.setDetectorUpdates(detectorUpdates); | ||
|
||
UpdateParams params = UpdateParams.fromJobUpdate(updateBuilder.build()); | ||
|
||
assertFalse(params.isUpdateScheduledEvents()); | ||
assertEquals(params.getDetectorUpdates(), updateBuilder.build().getDetectorUpdates()); | ||
assertEquals(params.getModelPlotConfig(), updateBuilder.build().getModelPlotConfig()); | ||
|
||
updateBuilder.setGroups(Arrays.asList("bar")); | ||
|
||
params = UpdateParams.fromJobUpdate(updateBuilder.build()); | ||
|
||
assertTrue(params.isUpdateScheduledEvents()); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Why not call this earlier where the rest of the update is built? There is no reason to separate the groups from this test's perspective.