Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLRC: adding machine learning delete job #32820

Merged
merged 6 commits into from
Aug 16, 2018
Merged

HLRC: adding machine learning delete job #32820

merged 6 commits into from
Aug 16, 2018

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Aug 13, 2018 •
edited
Loading

This adds the DELETE Job call for the Machine Learning client in the HLRC.

Relates to #29827

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor

Did you try building the docs into HTML? If not, this is what to do:

git clone [email protected]:elastic/docs.git
cd docs
./build_docs.pl --doc ~/elasticsearch/docs/java-rest/index.asciidoc
open html_docs/index.html

(If you haven't cloned the elasticsearch repo in your home directory then change ~ to wherever in the commands above. If you get an error about certificates then edit lib/ES/Util.pm in the docs repo and add a -k argument to the curl invocation.)

Then navigate to your new documentation page and make sure it looks sensible in your browser.

droberts195
droberts195 reviewed Aug 15, 2018
View reviewed changes
docs/java-rest/high-level/supported-apis.asciidoc Outdated

include::ml/put_job.asciidoc[]
include::ml/delete-job.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consistently use hyphens or underscores for all our doc files. Looking at what the other teams have done, there's no consistent choice, but files do seem to consistently use one or the other within the same directory. So please can you choose and rename one of the files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @droberts195

@benwtrent
Copy link
Member Author

@droberts195 yes, I have built the docs and looked through them to make sure they look ok.

droberts195
droberts195 approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou
Copy link
Contributor

@benwtrent I think after merging this is a good time for me to refactor the request converters into their own class. It shouldn't take me long.

@benwtrent benwtrent merged commit aedc2c1 into elastic:master Aug 16, 2018
benwtrent added a commit that referenced this pull request Aug 16, 2018
@benwtrent
HLRC: adding machine learning delete job (#32820)
6333e00 
* HLRC: adding machine learning delete job

* Fixing whitespace

* Moving docs and tests around

* Unifying ml asciidoc file naming convention
@benwtrent benwtrent deleted the feature/hlrc-ml-delete-job branch August 16, 2018 12:21
jimczi pushed a commit that referenced this pull request Aug 17, 2018
@benwtrent @jimczi
HLRC: adding machine learning delete job (#32820)
2d056a2 
* HLRC: adding machine learning delete job

* Fixing whitespace

* Moving docs and tests around

* Unifying ml asciidoc file naming convention
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Aug 24, 2018
@jasontedor
Merge branch 'master' of github.com:elastic/elasticsearch into global…
bd61738 
…-checkpoint-poll

* 'master' of github.com:elastic/elasticsearch:
  Fix docs for fixed filename for heap dump path (elastic#32882)
  Painless: Special Case def (elastic#32871)
  AwaitFix FullClusterRestartIT#testRollupIDSchemeAfterRestart.
  [Test] Fix DuelScrollIT#testDuelIndexOrderQueryThenFetch
  HLRC: adding machine learning delete job (elastic#32820)
  [DOCS] Update WordPress plugins links (elastic#32194)
  Remove passphrase support from reload settings API (elastic#32889)
  AwaitFix AckIT.
  Mutes test in DuelScrollIT
  CharArraysTests: Fix test bug.
  [ML] Choose seconds to fix intermittent DatafeeedConfigTest failure
  Test: Fix unpredictive merges in DocumentSubsetReaderTests
  [DOCS] Clarify sentence in network-host.asciidoc (elastic#32429)
  Docs enhancement: added reference to cluster-level setting `search.default_allow_partial_results` (elastic#32810)
  [DOCS] Fixing cross doc link to Stack Overview security topic.
  Move CharArrays to core lib (elastic#32851)
  Fix global checkpoint listeners test
  HLRC: adding machine learning open job (elastic#32860)
  [ML] Add log structure finder functionality (elastic#32788)
  INGEST: Add Configuration Except. Data to Metdata (elastic#32322)
@elasticmachine elasticmachine mentioned this pull request Aug 27, 2018
Closed
98 tasks
@benwtrent benwtrent added >enhancement and removed :ml Machine learning >feature labels Oct 25, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

Assignees
No one assigned
Labels
>enhancement v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benwtrent @elasticmachine @droberts195 @dimitris-athanasiou @jimczi