Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure KeyStoreWrapper decryption exceptions are handled #32464

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Ensure KeyStoreWrapper decryption exceptions are handled #32464

merged 3 commits into from
Jul 30, 2018

Commits on Jul 30, 2018

  1. Ensure decryption related exceptions are handled 

    This commit ensures that all possible Exceptions in
KeyStoreWrapper#decrypt() are handled. More specifically, in the
case that a wrong password is used for secure settings, calling readX
on the DataInputStream that wraps the CipherInputStream can throw an
IOException. It also adds a test for loading a KeyStoreWrapper with
a wrong password.
    @jkakavas
    jkakavas committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    8180f47 View commit details
    Browse the repository at this point in the history

  2. Remove unused import

    @jkakavas
    jkakavas committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    c8b4968 View commit details
    Browse the repository at this point in the history

  3. Correct the test

    @jkakavas
    jkakavas committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    bacfb77 View commit details
    Browse the repository at this point in the history