Add second level of field collapsing #31808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search-aggs |
jimczi
reviewed
Jul 5, 2018
There was a problem hiding this comment.
It looks good @mayya-sharipova but I wonder if the second collapse should be under inner_hits ? I know we discussed the proposed format already but I forgot that we can have multiple inner_hits in a single collapse so it would be more flexible and consistent to define the collapse field there ?
|
@jimczi Thanks Jim, I will try to implement |
|
@jimczi I have modified the PR to make the second level collapse under |
jimczi
approved these changes
Jul 12, 2018
mayya-sharipova
added a commit
that referenced
this pull request
Jul 13, 2018
Put second level collapse under inner_hits Closes #24855
dnhatn
added a commit
that referenced
this pull request
Jul 13, 2018
* 6.x: Watcher: Make settings reloadable (#31746) [Rollup] Histo group config should support scaled_floats (#32048) lazy snapshot repository initialization (#31606) Add secure setting for watcher email password (#31620) Watcher: cleanup ensureWatchExists use (#31926) Add second level of field collapsing (#31808) Added lenient flag for synonym token filter (#31484) (#31970) Test: Fix a second case of bad watch creation [Rollup] Use composite's missing_bucket (#31402) Docs: Restyled cloud link in getting started Docs: Change formatting of Cloud options Re-instate link in StringFunctionUtils javadocs Correct spelling of AnalysisPlugin#requriesAnalysisSettings (#32025) Fix problematic chars in javadoc [ML] Move open job failure explanation out of root cause (#31925) [ML] Switch ML native QA tests to use a 3 node cluster (#32011)
jimczi
added a commit
that referenced
this pull request
Jul 16, 2018
89 tasks
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 1, 2018
russcam
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 17, 2018
russcam
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 26, 2018
as per elastic/elasticsearch#31808 (cherry picked from commit 7d78767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24855