Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NoopEngine -> NoOpEngine #31398

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Rename NoopEngine -> NoOpEngine #31398

merged 1 commit into from
Jun 19, 2018

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 18, 2018

In #31163 (comment)
Jason requested renaming NoopEngine to NoOpEngine. This commit renames the class
and relevant parts.

Relates to #31141

@dakrone
Rename NoopEngine -> NoOpEngine
f86f71d 
In elastic#31163 (comment)
Jason requested renaming NoopEngine to NoOpEngine. This commit renames the class
and relevant parts.

Relates to elastic#31141
@dakrone dakrone added >non-issue review :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. labels Jun 18, 2018
bleskes
bleskes approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone merged commit fc63e6c into elastic:closed-index-replication Jun 19, 2018
@dakrone
Copy link
Member Author

dakrone commented Jun 19, 2018

Thanks Boaz!

tlrx pushed a commit that referenced this pull request Sep 14, 2018
@dakrone @tlrx
Rename NoopEngine -> NoOpEngine (#31398)
5741915 
In #31163 (comment)
Jason requested renaming NoopEngine to NoOpEngine. This commit renames the class
and relevant parts.

Relates to #31141
tlrx pushed a commit to tlrx/elasticsearch that referenced this pull request Sep 26, 2018
@dakrone @tlrx
Rename NoopEngine -> NoOpEngine (elastic#31398)
580bef9 
In elastic#31163 (comment)
Jason requested renaming NoopEngine to NoOpEngine. This commit renames the class
and relevant parts.

Relates to elastic#31141
@dakrone dakrone deleted the rename-noop-for-jason branch February 4, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleskes bleskes bleskes approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakrone @bleskes