Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds changelog to Elasticsearch Reference #30271

Merged
merged 7 commits into from
May 1, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 30, 2018

Related to #29450

This PR replaces the use of release notes files with the use of the CHANGELOG.asciidoc file.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@lcawl lcawl force-pushed the lcawley-changelog branch from f11f1b3 to 507908f Compare April 30, 2018 21:27
@colings86 colings86 added the :Core/Infra/Core Core issues without another label label May 1, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@pcsanwald pcsanwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changelog locally by running perl Code/docs/build_docs.pl --doc ~/Desktop/CHANGELOG.asciidoc --open --lenient, and I noticed that the browser output looks strange, is this expected?

I'm wondering if the header might need to be the first thing or something.
screen shot 2018-05-01 at 7 29 04 am

@lcawl
Copy link
Contributor Author

lcawl commented May 1, 2018

@pcsanwald To see this properly, you need to build the Elasticsearch Reference. There are aliases for the build commands here: https://github.com/elastic/docs/blob/master/doc_build_aliases.sh (i.e. see docbldes or docbldesx)

@lcawl lcawl force-pushed the lcawley-changelog branch from 0ac9955 to b73ebc4 Compare May 1, 2018 16:13
Copy link
Contributor

@Sue-Gallagher Sue-Gallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/CHANGELOG.asciidoc - Line 6 - "...links to issue(s) and pulls."

Copy link
Contributor

@pcsanwald pcsanwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built docs, tested, everything looks good, 🚢 it!

@lcawl lcawl merged commit 5b5c98c into elastic:master May 1, 2018
@lcawl lcawl deleted the lcawley-changelog branch May 1, 2018 17:34
lcawl added a commit to lcawl/elasticsearch that referenced this pull request May 1, 2018
@lcawl lcawl removed the v6.4.0 label May 1, 2018
lcawl added a commit to lcawl/elasticsearch that referenced this pull request May 1, 2018
@lcawl lcawl removed the v6.3.0 label May 1, 2018
dnhatn added a commit that referenced this pull request May 2, 2018
* master: (68 commits)
  [DOCS] Removes X-Pack Elasticsearch release notes (#30272)
  Correct an example in the top-level suggester documentation. (#30224)
  [DOCS] Removes broken link
  [DOCS] Adds file realm configuration details (#30221)
  [DOCS] Adds PKI realm configuration details (#30225)
  Fix a reference to match_phrase_prefix in the match query docs. (#30282)
  Fix failure for validate API on a terms query (#29483)
  [DOCS] Fix 6.4-specific link in changelog (#30314)
  Remove RepositoriesMetaData variadic constructor (#29569)
  Test: increase authentication logging for debugging
  [DOCS] Removes redundant SAML realm settings (#30196)
  REST Client: Add Request object flavored methods (#29623)
  [DOCS] Adds changelog to Elasticsearch Reference (#30271)
  [DOCS] Fixes section error
  SQL: Teach the CLI to ignore empty commands (#30265)
  [DOCS] Adds Active Directory realm configuration details (#30223)
  [DOCS] Removes redundant file realm settings (#30192)
  [DOCS] Fixes users command name (#30275)
  Build: Move gradle wrapper jar to a dot dir (#30146)
  Build: Log a warning if disabling reindex-from-old (#30304)
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants