Abort early on finding duplicate snapshot name in internal structures #29634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
tlrx
approved these changes
Apr 20, 2018
ywelsch
added a commit
that referenced
this pull request
Apr 20, 2018
…#29634) Adds a check in BlobstoreRepository.snapshot(...) that prevents duplicate snapshot names and fails the snapshot before writing out the new index file. This ensures that you cannot end up in this situation where the index file has duplicate names and cannot be read anymore . Relates to #28906
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 23, 2021
Today we prevent creating a shard snapshot whose name matches one that already exists (elastic#29634) but it's possible to end up with duplicate snapshot names anyway if the `index-N` file is unreadable and the fallback which reads all the `snap-UUID.dat` files encounters two with the same name, perhaps due to some earlier failure. This results in writing a broken `index-N` file that contains duplicate keys, which completely breaks the repository. This commit fails the shard snapshot without writing the broken `index-N` file in this situation, on the assumption that the unreadability of the existing `index-N` file is only temporary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check in
BlobstoreRepository.snapshot(...)that prevents duplicate snapshot names and fails the snapshot before writing out the new index file. This ensures that you cannot end up in this situation where the index file has duplicate names and cannot be read anymore .Relates to #28906