Implement Iterator#remove for Cache values iter #29633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the ability to remove values from a Cache using the values iterator. This brings the values iterator in line with the keys iterator and adds support for removing items in the cache that are not easily found by the key used for the cache.
jaymode
added
>enhancement
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
thanks @jasontedor |
jaymode
added a commit
that referenced
this pull request
Apr 20, 2018
This commit implements the ability to remove values from a Cache using the values iterator. This brings the values iterator in line with the keys iterator and adds support for removing items in the cache that are not easily found by the key used for the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the ability to remove values from a Cache using
the values iterator. This brings the values iterator in line with the
keys iterator and adds support for removing items in the cache that are
not easily found by the key used for the cache.