Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max number of threads typo #29469

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Fix max number of threads typo #29469

merged 1 commit into from
Apr 13, 2018

Conversation

sachin-frayne
Copy link
Contributor

@jasontedor jasontedor self-requested a review April 11, 2018 11:10
@jasontedor jasontedor added >docs General docs changes :Core/Infra/Core Core issues without another label v7.0.0 v6.3.0 v6.2.4 labels Apr 11, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

jasontedor
jasontedor approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Historically this arose because we changed the bootstrap check from 2048 to 4096 at the 6.0.0 release; this documentation change appears to have been missed. Thank you for catching it. I will merge soon.

@jasontedor jasontedor merged commit 183ba9a into elastic:master Apr 13, 2018
jasontedor pushed a commit that referenced this pull request Apr 13, 2018
@sachin-frayne @jasontedor
Fix typo in max number of threads check docs (#29469)
7101588 
Historically, the bootstrap checks used 2048 as the minimum limit for
the maximum number of threads. This limit was guided by the fact that
the number of processors was artificially capped at 32. This limit was
removed in 6.0.0 and the minimum limit was raised to 4096 to accommodate
this. However, the docs were not updated and this commit addresses that
miss.
jasontedor pushed a commit that referenced this pull request Apr 13, 2018
@sachin-frayne @jasontedor
Fix typo in max number of threads check docs (#29469)
67aedc2 
Historically, the bootstrap checks used 2048 as the minimum limit for
the maximum number of threads. This limit was guided by the fact that
the number of processors was artificially capped at 32. This limit was
removed in 6.0.0 and the minimum limit was raised to 4096 to accommodate
this. However, the docs were not updated and this commit addresses that
miss.
@jasontedor
Copy link
Member

Thanks @antomos.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 13, 2018
@jasontedor
Merge branch 'master' into java-home-sweet-java-home
062d1ae 
* master:
  Enable skipping fetching latest for BWC builds (elastic#29497)
  Add remote cluster client (elastic#29495)
  Ensure flush happens on shard idle
  Adds SpanGapQueryBuilder in the query DSL (elastic#28636)
  Control max size and count of warning headers (elastic#28427)
  Make index APIs work without types. (elastic#29479)
  Deprecate filtering on `_type`. (elastic#29468)
  Fix auto-generated ID example format (elastic#29461)
  Fix typo in max number of threads check docs (elastic#29469)
  Add primary term to translog header (elastic#29227)
  Add a helper method to get a random java.util.TimeZone (elastic#29487)
  Move TimeValue into elasticsearch-core project (elastic#29486)
martijnvg added a commit that referenced this pull request Apr 13, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
9da3e73 
* es/master:
  Add remote cluster client (#29495)
  Ensure flush happens on shard idle
  Adds SpanGapQueryBuilder in the query DSL (#28636)
  Control max size and count of warning headers (#28427)
  Make index APIs work without types. (#29479)
  Deprecate filtering on `_type`. (#29468)
  Fix auto-generated ID example format (#29461)
  Fix typo in max number of threads check docs (#29469)
  Add primary term to translog header (#29227)
  Add a helper method to get a random java.util.TimeZone (#29487)
  Move TimeValue into elasticsearch-core project (#29486)
  Fix NPE in InternalGeoCentroidTests#testReduceRandom (#29481)
  Build: introduce keystoreFile for cluster config (#29491)
  test: Index more docs, so that it is less likely the search request does not time out.
martijnvg added a commit that referenced this pull request Apr 13, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
8b3f218 
* es/6.x:
  Enable skipping fetching latest for BWC builds (#29497)
  Add remote cluster client (#29495)
  Ensure flush happens on shard idle
  Adds SpanGapQueryBuilder in the query DSL (#28636)
  Fix auto-generated ID example format (#29461)
  Fix typo in max number of threads check docs (#29469)
  Add primary term to translog header (#29227)
  Add a helper method to get a random java.util.TimeZone (#29487)
  Move TimeValue into elasticsearch-core project (#29486)
  Fix NPE in InternalGeoCentroidTests#testReduceRandom (#29481)
  Build: introduce keystoreFile for cluster config (#29491)
  test: Index more docs, so that it is less likely the search request does not time out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes v6.2.4 v6.3.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sachin-frayne @elasticmachine @jasontedor @colings86