Switch to hardcoding Smile as the state format #28610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the state format that was previously passed in to `MetaDataStateFormat` to always use Smile. This doesn't actually change the format, since we have used Smile for writing the format since at least 5.0. This removes the automatic detection of the state format when reading state, since any state that could be processed in 6.x and 7.x would already have been written in Smile format. This is work towards removing the deprecated methods in the XContent code where we do automatic content-type detection. Relates to elastic#28504
dakrone
added
review
:Core/Infra/Core
nik9000
approved these changes
Feb 9, 2018
dakrone
added a commit
that referenced
this pull request
Feb 12, 2018
This commit changes the state format that was previously passed in to `MetaDataStateFormat` to always use Smile. This doesn't actually change the format, since we have used Smile for writing the format since at least 5.0. This removes the automatic detection of the state format when reading state, since any state that could be processed in 6.x and 7.x would already have been written in Smile format. This is work towards removing the deprecated methods in the XContent code where we do automatic content-type detection. Relates to #28504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the state format that was previously passed in to
MetaDataStateFormatto always use Smile. This doesn't actually change theformat, since we have used Smile for writing the format since at least 5.0. This
removes the automatic detection of the state format when reading state, since
any state that could be processed in 6.x and 7.x would already have been written
in Smile format.
This is work towards removing the deprecated methods in the XContent code where
we do automatic content-type detection.
Relates to #28504