Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gradle 4.3 #27249

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Add support for Gradle 4.3 #27249

merged 1 commit into from
Nov 3, 2017

Conversation

dadoonet
Copy link
Member

@dadoonet dadoonet commented Nov 3, 2017

Closes #26840
Related to #27087

@dadoonet dadoonet added the :Delivery/Build Build or test infrastructure label Nov 3, 2017
@dadoonet dadoonet requested a review from jasontedor November 3, 2017 11:12
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work for me on macOS and Linux. LGTM.

@dadoonet
Copy link
Member Author

dadoonet commented Nov 3, 2017

Thansk @jasontedor. Where should I backport it to? I guess same branches as #27087? 5.6, 6.0, 6.1 and master, right?

@jasontedor
Copy link
Member

@dadoonet The same branches indeed.

@dadoonet dadoonet merged commit 0635778 into elastic:master Nov 3, 2017
@dadoonet dadoonet deleted the pr/gradle43 branch November 3, 2017 13:37
dadoonet added a commit that referenced this pull request Nov 3, 2017
Closes #26840
Related to #27087

Backport of #27249 in 6.x branch
dadoonet added a commit that referenced this pull request Nov 3, 2017
Closes #26840
Related to #27087

Backport of #27249 in 5.6 branch
martijnvg added a commit that referenced this pull request Nov 4, 2017
* es/master:
  Fix snapshot getting stuck in INIT state (#27214)
  Add an example of dynamic field names (#27255)
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix InternalStatsTests
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
martijnvg added a commit that referenced this pull request Nov 4, 2017
* 6.x:
  Add an example of dynamic field names (#27255)
  fixed checkstyle violation
  #26260 Allow ip_range to accept CIDR notation (#27192)
  #27189 Fixed rounding of bounds in scaled float comparison (#27207)
  [TEST] Fix failing exists query test
  test: Do not run old parent/child tests against a cluster with minimum version greater than 6.0.0
  Add support for Gradle 4.3 (#27249)
  Fixes QueryStringQueryBuilderTests
  build: Fix setting the incorrect bwc version in mixed cluster qa module
  fix compil after backport
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC
  Adjust assertions for sequence numbers BWC tests
  Do not create directories if repository is readonly (#26909)
  [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery
  Uses norms for exists query if enabled (#27237)
  Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
jasontedor pushed a commit that referenced this pull request Nov 6, 2017
@dadoonet
Copy link
Member Author

I wonder if we should reopen #26840 and revert this patch.
With Gradle 4.3.1, I'm still hitting this problem from time to time.

@ywelsch
Copy link
Contributor

ywelsch commented Nov 23, 2017

@dadoonet I've figured out the remaining Gradle >= 4.2 issue with our build and will create a fix later today.

@dadoonet
Copy link
Member Author

Great news!

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.6.5 v6.0.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is failing with Gradle 4.2
6 participants