doc: deprecate _primary and _replica shard option #26792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnhatn we have special asciidoc syntax for deprecations, see: https://github.com/elastic/docs#additions-and-deprecations |
|
Thanks @dakrone. I will update it. |
jasontedor
requested changes
Oct 4, 2017
|
retest this please |
|
Thanks @jasontedor for the suggestion. I have added deprecation logging for these parameters. Could you please have another look? |
jasontedor
reviewed
Oct 4, 2017
| @@ -199,12 +199,20 @@ private ShardIterator preferenceActiveShardIterator(IndexShardRoutingTable index | |||
| case LOCAL: | |||
| return indexShard.preferNodeActiveInitializingShardsIt(Collections.singleton(localNodeId)); | |||
| case PRIMARY: | |||
| deprecationLogger.deprecated("[_primary] has been deprecated in 6.0+, and will be removed in 7.0; " + | |||
There was a problem hiding this comment.
The version here should be 6.1 (we are going to backport this to 6.x but not 6.0).
| @@ -9,18 +9,21 @@ The `preference` is a query string parameter which can be set to: | |||
| [horizontal] | |||
| `_primary`:: | |||
| The operation will go and be executed only on the primary | |||
| shards. | |||
| shards. deprecated[6.0.0, will be removed in 7.0, use `_only_nodes` or `_prefer_nodes`] | |||
| @@ -1,5 +1,10 @@ | |||
| --- | |||
| "List of strings": | |||
| - skip: | |||
| version: " - 5.99.99" | |||
dnhatn
added
v6.1.0
:Search/Search
|
@dnhatn Let's be careful when we merge this that the master branch does not break because of the BWC tests that use preferences. If you need help walking through how to test that locally, please let me know. |
jasontedor
approved these changes
Oct 4, 2017
|
@jasontedor The BWC tests are good for this branch. Thanks a lot for your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells v6 users that we are going to remove these options in v7.
Related #26335