-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yml test for json ingest processor #25972
Conversation
This tests should pass because JSON can accept one of these values.
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
thanks @Fahminajjar for reporting this. I'll take a look! Originally, the processor was not designed to support this, but I see no reason it shouldn't. |
hi @Fahminajjar could you please sign our CLA? Otherwise we can't get your change in. |
I signed the CLA. |
thank you! @talevy could you review this please? |
thank you for sharing these tests with us! Sorry it took so long to get to. Here is the PR #27335. I'll go ahead and close this PR/issue/feature-request once that is merged. |
The Json Processor originally only supported parsing field values into Maps even though the JSON spec specifies that strings, null-values, numbers, booleans, and arrays are also valid JSON types. This commit enables parsing these values now. response to elastic#25972.
The Json Processor originally only supported parsing field values into Maps even though the JSON spec specifies that strings, null-values, numbers, booleans, and arrays are also valid JSON types. This commit enables parsing these values now. response to #25972.
The Json Processor originally only supported parsing field values into Maps even though the JSON spec specifies that strings, null-values, numbers, booleans, and arrays are also valid JSON types. This commit enables parsing these values now. response to #25972.
Fixed in #27335. Let me know what you think @Fahminajjar! Should be good to go in ES 6.1 |
Thank you @talevy |
These tests should pass because JSON can accept one of these values.