-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 7.0.0-alpha1 #25876
Changes from 11 commits
9dafe7d
1cf8a14
092d749
793013e
f829ed2
0a014cf
a4df8db
d6e2c06
d01c7a2
22f7077
b0e4031
5685bcc
7c9b734
2defa14
268417a
b8f1162
cd3a0a4
ab11b83
37fa923
24431fb
22d8054
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,18 +79,20 @@ int lastPrevMinor = -1 // the minor version number from the prev major we most r | |
for (String line : versionLines) { | ||
/* Note that this skips alphas and betas which is fine because they aren't | ||
* compatible with anything. */ | ||
Matcher match = line =~ /\W+public static final Version V_(\d+)_(\d+)_(\d+) .*/ | ||
Matcher match = line =~ /\W+public static final Version V_(\d+)_(\d+)_(\d+)(_beta\d+|_rc\d+)? .*/ | ||
if (match.matches()) { | ||
int major = Integer.parseInt(match.group(1)) | ||
int minor = Integer.parseInt(match.group(2)) | ||
int bugfix = Integer.parseInt(match.group(3)) | ||
Version foundVersion = new Version(major, minor, bugfix, false) | ||
if (currentVersion != foundVersion) { | ||
if (currentVersion != foundVersion | ||
&& (major == prevMajor || major == currentVersion.major) | ||
&& (versions.isEmpty() || versions.last() != foundVersion)) { | ||
versions.add(foundVersion) | ||
} | ||
if (major == prevMajor && minor > lastPrevMinor) { | ||
prevMinorIndex = versions.size() - 1 | ||
lastPrevMinor = minor | ||
if (major == prevMajor && minor > lastPrevMinor) { | ||
prevMinorIndex = versions.size() - 1 | ||
lastPrevMinor = minor | ||
} | ||
} | ||
} | ||
} | ||
|
@@ -242,9 +244,11 @@ subprojects { | |
ext.projectSubstitutions["org.elasticsearch.distribution.deb:elasticsearch:${indexCompatVersions[-1]}"] = ':distribution:bwc-stable-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.rpm:elasticsearch:${indexCompatVersions[-1]}"] = ':distribution:bwc-stable-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.zip:elasticsearch:${indexCompatVersions[-1]}"] = ':distribution:bwc-stable-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.deb:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.rpm:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.zip:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
if (indexCompatVersions.size() > 1) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
ext.projectSubstitutions["org.elasticsearch.distribution.deb:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.rpm:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.zip:elasticsearch:${indexCompatVersions[-2]}"] = ':distribution:bwc-release-snapshot' | ||
} | ||
} else { | ||
ext.projectSubstitutions["org.elasticsearch.distribution.deb:elasticsearch:${indexCompatVersions[-1]}"] = ':distribution:bwc-release-snapshot' | ||
ext.projectSubstitutions["org.elasticsearch.distribution.rpm:elasticsearch:${indexCompatVersions[-1]}"] = ':distribution:bwc-release-snapshot' | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ | |
import org.elasticsearch.common.lucene.all.AllTermQuery; | ||
import org.elasticsearch.common.settings.Settings; | ||
import org.elasticsearch.common.xcontent.XContentBuilder; | ||
import org.elasticsearch.common.xcontent.json.JsonXContent; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. revert this? I don't see it being used. |
||
import org.elasticsearch.index.analysis.NamedAnalyzer; | ||
import org.elasticsearch.index.query.QueryShardContext; | ||
import org.elasticsearch.index.similarity.SimilarityService; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,6 @@ | |
|
||
import java.util.Collections; | ||
|
||
import static org.elasticsearch.test.VersionUtils.randomVersionBetween; | ||
import static org.hamcrest.Matchers.equalTo; | ||
import static org.hamcrest.Matchers.notNullValue; | ||
import static org.hamcrest.Matchers.nullValue; | ||
|
@@ -139,7 +138,7 @@ public void testSnapshotDeletionsInProgressSerialization() throws Exception { | |
|
||
// serialize with old version | ||
outStream = new BytesStreamOutput(); | ||
outStream.setVersion(Version.CURRENT.minimumIndexCompatibilityVersion()); | ||
outStream.setVersion(Version.V_5_0_0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why V_5_0_0? we should never serialize to such a node? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah so I think this test can go away but I didn't wanna do it in this PR. |
||
diffs.writeTo(outStream); | ||
inStream = outStream.bytes().streamInput(); | ||
inStream = new NamedWriteableAwareStreamInput(inStream, new NamedWriteableRegistry(ClusterModule.getNamedWriteables())); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this adds all the betas and rcs are wire and index compatible versions. I think, at least in the end, we want them to only be index and wire compatible if we only have only have them. Otherwise we'll be testing compatibility against betas while we're well into 6.0. Is this a thing we should handle in a followup?