Fix _field_caps serialization in order to support cross cluster search
#24722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the `_field_caps` API doesn't implement its request serialization correctly since indices and indices options are not serialized at all. This will likely break with all transport clients etc. and if this request must be send across the network. This commit fixes this and adds correct handling if we have only remote indices to prevent the inclusion of all local indices.
nik9000
approved these changes
May 16, 2017
javanna
approved these changes
May 16, 2017
jimczi
approved these changes
May 16, 2017
|
Works will with elastic/kibana#11114 |
jimczi
approved these changes
May 17, 2017
javanna
reviewed
May 17, 2017
|
|
||
| // change indices options | ||
| other.indicesOptions(IndicesOptions.strictExpand()); | ||
| assertNotEquals(request, other); |
There was a problem hiding this comment.
maybe you can use EqualsHashCodeTestUtils#checkEqualsAndHashCode and save yourself some boilerplate here?
s1monw
added a commit
that referenced
this pull request
May 17, 2017
…rch (#24722) Today the `_field_caps` API doesn't implement its request serialization correctly since indices and indices options are not serialized at all. This will likely break with all transport clients etc. and if this request must be send across the network. This commit fixes this and adds correct handling if we have only remote indices to prevent the inclusion of all local indices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the
_field_capsAPI doesn't implement its request serializationcorrectly since indices and indices options are not serialized at all.
This will likely break with all transport clients etc. and if this request
must be send across the network. This commit fixes this and adds correct
handling if we have only remote indices to prevent the inclusion of
all local indices.