Tests: Change rest test extension from .yaml to .yml #24659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames all rest test files to use the .yml extension instead of .yaml. This way the extension used within all of elasticsearch for yaml is consistent.
bleskes
approved these changes
May 14, 2017
|
Makes sense to me.
…On Sun, May 14, 2017, 5:18 AM Boaz Leskes ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#24659 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLot0ZWZY_6qq9msQvK0sv1OdAJxBXks5r5sbvgaJpZM4NaRWg>
.
|
|
@clintongormley I assume the clients will need to be updated before pushing this? |
I don't think the clients have CI enabled atm, so you should be able to go ahead and merge. Ping: @elastic/es-clients - the YAML test files are being renamed from |
|
I've checked and I load both .yml and .yaml files, so Travis should continue to work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames all rest test files to use the .yml extension
instead of .yaml. This way the extension used within all of
elasticsearch for yaml is consistent.
see #24633 (comment)